Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files Errors
47 423

Files

Files Errors
inklings/jgatms/CommandKeys.java 13
inklings/jgatms/ContextKeys.java 21
inklings/jgatms/action/BaseAction.java 39
inklings/jgatms/action/package.html 1
inklings/jgatms/bean/Member.java 120
inklings/jgatms/bean/Question.java 22
inklings/jgatms/bean/QuestionResponseProfile.java 16
inklings/jgatms/bean/Response.java 15
inklings/jgatms/bean/Skill.java 22
inklings/jgatms/bean/SkillLevel.java 15
inklings/jgatms/bean/SkillProfile.java 36
inklings/jgatms/bean/State.java 15
inklings/jgatms/bean/package.html 1
inklings/jgatms/command/AddResponseToQuestion.java 7
inklings/jgatms/command/BaseCommand.java 8
inklings/jgatms/command/BuildSessionFactory.java 8
inklings/jgatms/command/GetMemberList.java 9
inklings/jgatms/command/GetQuestion.java 11
inklings/jgatms/command/GetQuestions.java 8
inklings/jgatms/command/GetResponses.java 8
inklings/jgatms/command/GetSkillsList.java 8
inklings/jgatms/command/OpenSession.java 6
inklings/jgatms/command/package.html 1
inklings/jgatms/context/JgatmsContext.java 11
inklings/jgatms/context/package.html 1
inklings/jgatms/package.html 1

inklings/jgatms/CommandKeys.java

Error Line
Missing a header - not enough lines in file. 1
Line has trailing spaces. 8
Class CommandKeys should be declared as final. 11
'{' is not followed by whitespace. 14
'}' is not preceeded with whitespace. 14
Missing a Javadoc comment. 16
Missing a Javadoc comment. 17
Missing a Javadoc comment. 18
Line has trailing spaces. 19
Missing a Javadoc comment. 19
Missing a Javadoc comment. 21
Missing a Javadoc comment. 22
Missing a Javadoc comment. 23

inklings/jgatms/ContextKeys.java

Error Line
Missing a header - not enough lines in file. 1
Class ContextKeys should be declared as final. 7
'{' is not followed by whitespace. 10
'}' is not preceeded with whitespace. 10
Missing a Javadoc comment. 12
Missing a Javadoc comment. 13
Missing a Javadoc comment. 14
Missing a Javadoc comment. 15
Line has trailing spaces. 18
Missing a Javadoc comment. 18
Missing a Ja vadoc comment. 20
Line has trailing spaces. 21
Missing a Javadoc comment. 24
Missing a Javadoc comment. 25
Missing a Javadoc comment. 26
Missing a Javadoc comment. 27
Missing a Javadoc comment. 28
Missing a Javadoc comment. 29
Missing a Javadoc comment. 30
Missing a Javadoc comment. 31
Line has trailing spaces. 32

inklings/jgatms/action/BaseAction.java

Error Line
Missing a header - not enough lines in file. 1
Line has trailing spaces. 18
'{' should be on the previous line. 22
Line has trailing spaces. 29
Unused @param tag for 'form.'. 31
Unused @param tag for 'request.'. 32
Unused @param tag for 'respone.'. 34
Method 'execute' is not designed for extension - needs to be abstract, final or empty. 39
Parameter mapping should be final. 39
Parameter f orm should be final. 40
Expected @param tag for 'form'. 40
Parameter request should be final. 41
Expected @param tag for 'request'. 41
Parameter response should be final. 42
Expected @param tag for 'response'. 42
'{' should be on the previous line. 44
'{' should be on the previous line. 46
'if' construct must use '{}'s. 48
'else' construct must use '{}'s. 50
Unused @param tag for 'form.'. 65
Unused @param tag for 'request.'. 66
Unused @param tag for 'respone.'. 68
Parameter mapping should be final. 73
Parameter form should be final. 74
Expected @param tag for 'form'. 74
Parameter request should be final. 75
Expected @param tag for 'request'. 75
Parameter response should be final. 76
Expected @param tag for 'response'. 76
Line has trailing spaces. 83
Unused @param tag for 'mapping.'. 86
Expected an @return tag. 89
Method 'createFormInstance' is not designed for extension - needs to be abstract, final or empty. 89
Parameter mapping should be final. 89
Expected @param tag for 'mapping'. 89
'{' should be on the previous line. 91
Line has trailing spaces. 92
Line has trailing spaces. 94
Line has trailing spaces. 96

inklings/jgatms/action/package.html

Error Lin e
Missing package documentation file. 0

inklings/jgatms/bean/Member.java

Error Line
Line does not match expected header line of ''. 1
Missing a Javadoc comment. 10
Missing a Javadoc comment. 11
Missing a Javadoc comment. 12
Missing a Javadoc comment. 13
Missing a Javadoc comment. 14
Missing a Javadoc comment. 15
Missing a Javadoc comment. 16
Missing a Javadoc comment. 17
Missing a Javadoc comment. 18
Missing a Javadoc comment. 19
Missing a Javadoc comment. 20
Missing a Javadoc comment. 21
Missing a Javadoc comment. 22
Missing a Javadoc comment. 23
Missing a Javadoc comment. 24
Missing a Javadoc comment. 25
Missing a Javadoc comment. 26
Expected an @return tag. 31
Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. 31
Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. 38
Parameter firstName should be final. 38
'firstName' hides a field. 38
Expected @param tag for 'firstName'. 38
Expected an @return tag. 45
Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. 45
Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. 52
Parameter lastName should be final. 52
'lastName' hides a field. 52
Expected @param tag for 'lastName'. 52
Expected an @return tag. 59
Method 'getGender' is not designed for extension - needs to be abstract, final or empty. 59
Method 'setGender' is not designed for extension - needs to be abstract, final or empty. 66
Parameter gender should be final. 66
'gender' hides a field. 66
Expected @param tag for 'gender'. 66
Expected an @return tag. 73
Method 'getAddress1' is not designed for extension - needs to be abstract, final or empty. 73
Method 'setAddress1' is not designed for extension - needs to be abstract, final or empty. 80
Parameter address1 should be final. 80
'address1' hides a field. 80
Expected @param tag for 'address1'. 80
Expected an @return tag. 87
Method 'getAddress2' is not designed for extension - needs to be abstract, final or empty. 87
Method 'setAddress2' is not designed for extension - needs to be abstract, final or empty. 94
Parameter address2 should be final. 94
'address2' hides a field. 94
Expected @param tag for 'address2'. 94
Expected an @return tag. 101
Method 'getCity' is not designed for extension - needs to be abstract, final or empty. 101
Method 'setCity' is not designed for extension - needs to be abstract, final or empty. 108
Parameter city should be final. 108
'city' hides a field. 108
Expected @param tag for 'city'. 108
Expected an @return tag. 115
Method 'getState' is not designed for extension - needs to be abstract, final or empty. 115
Method 'setState' is not designed for extension - needs to be abstract, final or empty. 122
Parameter state should be final. 122
'state' hides a field. 122
Expected @param tag for 'state'. 122
Expected an @return tag. 129
Method 'getZipCode' is not designed for extension - needs to be abstract, final or empty. 129
Method 'setZipCode' is not designed for extension - needs to be abstract, final or empty. 136
Parameter zipCode should be final. 136
'zipCode' hides a field. 136
Expected @param tag for 'zipCode'. 136
Expected an @return tag. 143
Method 'getHomePhone' is not designed for extension - needs to be abstract, final or empty. 143
Method 'setHomePhone' is not designed for extension - needs to be abstract, final or empty. 150
Parameter homePhone should be final. 150
'homePhone' hides a field. 150
Expected @param tag for 'homePhone'. 150
Expected an @return tag. 157
Method 'getWorkPhone' is not designed for extension - needs to be abstract, final or empty. 157
Method 'setWorkPhone' is not designed for extension - needs to be abstract, final or empty. 164
Parameter workPhone should be final. 164
'workPhone' hides a field. 164
Expected @param tag for 'workPhone'. 164
Expected an @return tag. 171
Method 'getMobilePhone' is not designed for extension - needs to be abstract, final or empty. 171
Method 'setMobilePhone' is not designed for extension - needs to be abstract, final or empty. 178
Parameter mobilePhone should be final. 178
'mobilePhone' hides a field. 178
Expected @param tag for 'mobilePhone'. 178
Expected an @return tag. 185
Method 'getPreferredPhone' is not designed for extension - needs to be abstract, final or empty. 185
Method 'setPreferredPhone' is not designed for extension - needs to be abstract, final or empty. 192
Parameter preferredPhone should be final. 192
'preferredPhone' hides a field. 192
Expected @param tag for 'preferredPhone'. 192
Expected an @return tag. 199
Method 'getEmailAddress' is not designed for extension - needs to be abstract, final or empty. 199
Method 'setEmailAddress' is not designed for extension - needs to be abstract, final or empty. 206
Parameter emailAddress should be final. 206
'emailAddress' hides a field. 206
Expected @param tag for 'emailAddress'. 206
Expected an @return tag. 213
Method 'getUserName' is not designed for extension - needs to be abstract, final or empty. 213
Method 'setUserName' is not designed for extension - needs to be abstract, final or empty. 220
Parameter userName should be final. 220
'userName' hides a field. 220
Expected @param tag for 'userName'. 220
Expected an @return tag. 227
Method 'getPassword' is not designed for extension - needs to be abstract, final or empty. 227
Method 'setPassword' is not designed for extension - needs to be abstract, final or empty. 234
Parameter password should be final. 234
'password' hides a field. 234
Expected @param tag for 'password'. 234
Expected an @return tag. 241
Method 'getMemberId' is not designed for extension - needs to be abstract, final or empty. 241
Method 'setMemberId' is not designed for extension - needs to be abstract, final or empty. 248
Parameter memberId should be final. 248
'memberId' hides a field. 248
Expected @param tag for 'memberId'. 248
Expected an @return tag. 255
Method 'getSkills' is not designed for extension - needs to be abstract, final or empty. 255
Method 'setSkills' is not designed for extension - needs to be abstract, final or empty. 262
Parameter skills should be final. 262
'skills' hides a field. 262
Expected @param tag for 'skills'. 262

inklings/jgatms/bean/Question.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 10
Missing a Javadoc comment. 11
Missing a Javadoc comment. 12
Expected an @return tag. 17
Method 'getQuestionId' is not designed for extension - needs to be abstract, final or empty. 17
Method 'setQuestionId' is not designed for extension - needs to be abstract, final or empty. 24
Parameter questionId should be final. 24
'questionId' hides a field. 24
Expected @param tag for 'questionId'. 24
Expected an @return tag. 31
Method 'getQuestion' is not designed for extension - needs to be abstract, final or empty. 31
Method 'setQuestion' is not designed for extension - needs to be abstract, final or empty. 38
Parameter question should be final. 38
'question' hides a field. 38
Expected @param tag for 'questi on'. 38
Expected an @return tag. 45
Method 'getPossibleResponses' is not designed for extension - needs to be abstract, final or empty. 45
Method 'setPossibleResponses' is not designed for extension - needs to be abstract, final or empty. 52
Parameter possibleResponses should be final. 52
'possibleResponses' hides a field. 52
Expected @param tag for 'possibleResponses'. 52

inklings/jgatms/bean/QuestionResponseProfile.java

Error Line
Missing a header - not enough lines in file. 1
Unused import - java.util.List. 3
Missing a Javadoc comment. 10
Missing a Javadoc comment. 11
Expected an @return tag. 16
Method 'getQuestion' is not designed for extension - needs to be abstract, final or empty. 16
Method 'setQuestion' is not designed for extension - needs to be abstract, final or empty. 23
Parameter question should be final. 23
'question' hides a field. 23
Expected @param tag for 'question'. 23
Expected an @return tag. 30
Method 'getResponse' is not designed for extension - needs to be abstract, final or empty. 30
Method 'setResponse' is not designed for extension - needs to be abstract, final or empty. 37
Parameter response should be final. 37
'response' hides a field. 37
Expected @param tag for 'response'. 37

inklings/jgatms/bean/Response.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 8
Missing a Javadoc comment. 9
Expected an @return tag. 14
Method 'getResponseId' is not designed for extension - needs to be abstract, final or empty. 14
Method 'setResponseId' is not designed for extension - needs to be abstract, final or empty. 21
Parameter responseId should be final. 21
'responseId' hides a field. 21
Expected @param tag for 'responseId'. 21
Expected an @return tag. 28
Method 'getResponse' is not designed for extension - needs to be abstract, final or empty. 28
Method 'setResponse' is not designed for extension - needs to be abstract, final or empty. 35
Parameter response should be final. 35
'response' hides a field. 35
Expected @param tag for 'response'. 35

inklings/jgatms/bean/Skill.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 10
Missing a Javadoc comment. 11
Missing a Javadoc comment. 12
Expected an @return tag. 17
Method 'getSkillId' is not designed for extension - needs to be abstract, final or empty. 17
Method 'setSkillId' is not designed for extension - needs to be abstract, final or empty. 24
Par ameter skillId should be final. 24
'skillId' hides a field. 24
Expected @param tag for 'skillId'. 24
Expected an @return tag. 31
Method 'getName' is not designed for extension - needs to be abstract, final or empty. 31
Method 'setName' is not designed for extension - needs to be abstract, final or empty. 38
Parameter name should be final. 38
'name' hides a field. 38
Expected @param tag for 'name'. 38
Expected an @return tag. 45
Method 'getQuestions' is not designed for extension - needs to be abstract, final or empty. 45
Method 'setQuestions' is not designed for extension - needs to be abstract, final or empty. 52
Parameter questions should be final. 52
'questions' hides a field. 52
Expected @param tag for 'questions'. 52

inklings/jgatms/bean/SkillLevel.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 8
Missing a Javadoc comment. 9
Expected an @return tag. 14
Method 'getLevelId' is not designed for extension - needs to be abstract, final or empty. 14
Method 'setLevelId' is not designed for extension - needs to be abstract, final or empty. 21
Parameter levelId should be final. 21
'levelId' hides a field. 21
Expected @param tag for 'levelId'. 21
Expected an @return tag. 28
Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. 28
Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. 35
Parameter description should be final. 35
'description' hides a field. 35
Expected @param tag for 'description'. 35

inklings/jgatms/bean/SkillProfile.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 10
Missing a Javadoc comment. 11
Missing a Javadoc comment. 12
Missing a Javadoc comment. 13
Missing a Javadoc comment. 14
Expected an @return tag. 19
Method 'getSkillProfileId' is not designed for extension - needs to be abstract, final or empty. 19
Method 'setSkillProfileId' is not designed for extension - needs to be abstract, final or empty. 26
Parameter skillProfileId should be final. 26
'skillProfileId' hides a field. 26
Expected @param tag for 'skillProfileId'. 26
Expected an @return tag. 33
Method 'getMember' is not designed for extension - needs to be abstract, final or empty. 33
Method 'setMember' is not designed for extension - needs to be abstract, final or empty. 40
Parameter member should be final. 40
'member' hides a field. 40
Expected @param tag fo r 'member'. 40
Expected an @return tag. 47
Method 'getSkillLevel' is not designed for extension - needs to be abstract, final or empty. 47
Method 'setSkillLevel' is not designed for extension - needs to be abstract, final or empty. 54
Parameter skillLevel should be final. 54
'skillLevel' hides a field. 54
Expected @param tag for 'skillLevel'. 54
Expected an @return tag. 61
Method 'getSkill' is not designed for extension - needs to be abstract, final or empty. 61
Method 'setSkill' is not designed for extension - needs to be abstract, final or empty. 68
Parameter skill should be final. 68
'skill' hides a field. 68
Expected @param tag for 'skill'. 68
Expected an @return tag. 75
Method 'getQuestionResponses' is not designed for extension - needs to be abstract, final or empty. 75
Method 'setQuestionResponses' is not designed for extension - needs to be abstract, final or empty. 82
Parameter questionResponses should be final. 82
'questionResponses' hides a field. 82
Expected @param tag for 'questionResponses'. 82

inklings/jgatms/bean/State.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 8
Missing a Javadoc comment. 9
Expected an @return tag. 14
Method 'getStateId' is not designed for extension - needs to be abstract, final or empty. 14
Method 'setStateId' is not designed for extension - needs to be abstract, final or empty. 21
Parameter stateId should be final. 21
'stateId' hides a field. 21
Expected @param tag for 'stateId'. 21
Expected an @return t ag. 28
Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. 28
Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. 35
Parameter description should be final. 35
'description' hides a field. 35
Expected @param tag for 'description'. 35

inklings/jgatms/bean/package.html

Error Line
Missing package documentation file. 0

inklings/jgatms/command/AddResponseToQuestion.java

Error Line
Missing a header - not enough lines in file. 1
Unused import - java.util.List. 4
Missing a Javadoc comment. 24
Method 'execute' is not designed for extension - needs to be abstract, final or empty. 26
Missing a Javadoc comment. 26
Parameter context should be final. 26
'if' construct must use '{}'s. 65

inklings/jgatms/command/BaseCommand.java

Error Line
Missing a header - not enough lines in file. 1
Unused import - org.apache.commons.chain.Context. 5
Method 'getHibernateSessionKey' is not designed for extension - needs to be abstract, final or empty. 16
Missing a Javadoc comment. 16
Method 'getHibernateSessionFactoryKey' is not designed for extension - needs to be abstract, final or empty. 20
Missing a Javadoc comment. 20
Method 'getDispatchKey' is not designed for extension - needs to be abstract, final or empty. 24
Missing a Javadoc comment. 24

inklings/jgatms/command/BuildSessionFactory.java

Error Line
Missing a header - not enough lines in file. 1
Unused import - java.util.List. 4
Unused import - net.sf.hibernate.Session. 6
Missing a Javadoc comment. 24
Method 'execute' is not designed for extension - needs to be abstract, final or empty. 26
Missing a Javadoc comment. 26
Parameter context should be final. 26
Line has trailing spaces. 36

inklings/jgatms/command/GetMemberList.java

Error Line
Missing a header - not enough lines in file. 1
Unused import - inklings.jgatms.bean.Question. 13
Missing a Javadoc comment. 22
Method 'getMembersKey' is not designed for extension - needs to be abs tract, final or empty. 24
Missing a Javadoc comment. 24
Method 'execute' is not designed for extension - needs to be abstract, final or empty. 28
Missing a Javadoc comment. 28
Parameter context should be final. 28
'if' construct must use '{}'s. 49

inklings/jgatms/command/GetQuestion.java

Error Line
Missing a header - not enough lines in file. 1
Unused import - java.util.List. 4
Missing a Javadoc comment. 22
Method 'getQuestionKey' is not designed for extension - needs to be abstract, final or empty. 24
Missing a Javadoc comment. 24
Method 'getQuestionIdKey' is not designed for extension - needs to be abstract, final or empty. 28
Missing a Javadoc comment. 28
Method 'execute' is not designed for extension - needs to be abstract, final or empty. 32
Missing a Javadoc comment. 32
Parameter context should be final. 32
'if' construct must use '{}'s. 58

inklings/jgatms/command/GetQuestions.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 21
Method 'getQuestionsKey' is not designed for extension - needs to be abstract, final or empty. 23
Missing a Javadoc comment. 23
Method 'execute' is not designed for extension - needs to be abstract, final or empty. 27
Missing a Javadoc comment. 27
Parameter context should be final. 27
'if' construct must use '{}'s. 48

inklings/jgatms/command/GetResponses.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 21
Method 'getResponsesKey' is not designed for extension - needs to be abstract, final or empty. 23
Missing a Javadoc comment. 23
Method 'execute' is not designed for extension - needs to be abstract, final or empty. 27
Missing a Javadoc comment. 27
Parameter context should be final. 27
'if' construct must use '{}'s. 48

inklings/jgatms/command/GetSkillsList.java

Error Line
Missing a header - not enough lines in file. 1
Missing a Javadoc comment. 21
Method 'getSkillsKey' is not designed for extension - needs to be abstract, final or empty. 23
Missing a Javadoc comment. 23
Method 'execute' is not designed for extension - needs to be abstract, final or empty. 27
Missing a Javadoc comment. 27
Parameter context should be final. 27
'if' construct must use '{}'s. 48

inklings/jgatms/command/OpenSession.java

Error Line
Missing a header - not enough lines in file. 1
Unused import - java.util.List. 5
Missing a Javadoc comment. 24
Method 'execute' is not designed for extension - needs to be abstract, final or empty. 26
Missing a Javadoc comment. 26
Parameter context should be final. 26

inklings/jgatms/command/package.html

Error Line
Missing package documentation file. 0

inklings/jgatms/context/JgatmsContext.java

Error Line
Missing a header - not enough lines in file. 1
Expected an @return tag. 20
Method 'getMember' is not designed for extension - needs to be abstract, final or empty. 20
Method 'setMember' is not designed for extension - needs to be abstract, final or empty. 27
Parameter member should be final. 27
Expected @param tag for 'member'. 27
Expected an @return tag. 34
Method 'getDispatch' is not designed for extension - needs to be abstract, final or empty. 34
Method 'setDispatch' is not designed for extension - needs to be abstract, final or empty. 41
Parameter dispatch should be final. 41
Expected @param tag for 'dispatch'. 41

inklings/jgatms/context/package.html

Error Line
Missing package documentation file. 0

inklings/jgatms/package.html

Error Line
Missing package documentation file. 0